Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
M2 content provisioning
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TechDivision Public
M2 content provisioning
Commits
785de67d
Commit
785de67d
authored
5 years ago
by
Vadim Justus
Browse files
Options
Downloads
Patches
Plain Diff
#17
Remove return types and type hints for factory generation
parent
f375cfbe
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!21
#17 Fix type hint issues in Magento 2.1 and 2.2
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
Api/Data/EntryInterface.php
+10
-10
10 additions, 10 deletions
Api/Data/EntryInterface.php
Model/BlockEntry.php
+10
-10
10 additions, 10 deletions
Model/BlockEntry.php
Model/PageEntry.php
+10
-10
10 additions, 10 deletions
Model/PageEntry.php
with
30 additions
and
30 deletions
Api/Data/EntryInterface.php
+
10
−
10
View file @
785de67d
...
...
@@ -14,50 +14,50 @@ interface EntryInterface
/**
* @return string
*/
public
function
getKey
()
:
string
;
public
function
getKey
();
/**
* @param string $key
*/
public
function
setKey
(
string
$key
):
void
;
public
function
setKey
(
$key
)
;
/**
* @return bool
*/
public
function
isMaintained
()
:
bool
;
public
function
isMaintained
();
/**
* @param bool $isMaintained
*/
public
function
setIsMaintained
(
bool
$isMaintained
)
:
void
;
public
function
setIsMaintained
(
$isMaintained
);
/**
* @return array
*/
public
function
getStores
()
:
array
;
public
function
getStores
();
/**
* @param array $stores
*/
public
function
setStores
(
array
$stores
)
:
void
;
public
function
setStores
(
array
$stores
);
/**
* @return string
*/
public
function
getMediaDirectory
()
:
string
;
public
function
getMediaDirectory
();
/**
* @param string $path
*/
public
function
setMediaDirectory
(
string
$path
):
void
;
public
function
setMediaDirectory
(
$path
)
;
/**
* @return array
*/
public
function
getMediaFiles
()
:
array
;
public
function
getMediaFiles
();
/**
* @param array $files
*/
public
function
setMediaFiles
(
array
$files
)
:
void
;
public
function
setMediaFiles
(
array
$files
);
}
This diff is collapsed.
Click to expand it.
Model/BlockEntry.php
+
10
−
10
View file @
785de67d
...
...
@@ -11,7 +11,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @return string
*/
public
function
getKey
()
:
string
public
function
getKey
()
{
return
(
string
)
$this
->
getData
(
BlockEntryInterface
::
KEY
);
}
...
...
@@ -19,7 +19,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @param string $key
*/
public
function
setKey
(
string
$key
):
void
public
function
setKey
(
$key
)
{
$this
->
setData
(
BlockEntryInterface
::
KEY
,
$key
);
}
...
...
@@ -27,7 +27,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @return bool
*/
public
function
isMaintained
()
:
bool
public
function
isMaintained
()
{
return
(
bool
)
$this
->
getData
(
BlockEntryInterface
::
IS_MAINTAINED
);
}
...
...
@@ -35,7 +35,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @param bool $isMaintained
*/
public
function
setIsMaintained
(
bool
$isMaintained
)
:
void
public
function
setIsMaintained
(
$isMaintained
)
{
$this
->
setData
(
BlockEntryInterface
::
IS_MAINTAINED
,
$isMaintained
);
}
...
...
@@ -43,7 +43,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @return array
*/
public
function
getStores
()
:
array
public
function
getStores
()
{
return
(
array
)
$this
->
getData
(
BlockEntryInterface
::
STORES
);
}
...
...
@@ -51,7 +51,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @param array $stores
*/
public
function
setStores
(
array
$stores
)
:
void
public
function
setStores
(
array
$stores
)
{
$this
->
setData
(
BlockEntryInterface
::
STORES
,
$stores
);
}
...
...
@@ -59,7 +59,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @return string
*/
public
function
getMediaDirectory
()
:
string
public
function
getMediaDirectory
()
{
return
(
string
)
$this
->
getData
(
BlockEntryInterface
::
MEDIA_DIRECTORY
);
}
...
...
@@ -67,7 +67,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @param string $path
*/
public
function
setMediaDirectory
(
string
$path
):
void
public
function
setMediaDirectory
(
$path
)
{
$this
->
setData
(
BlockEntryInterface
::
MEDIA_DIRECTORY
,
$path
);
}
...
...
@@ -75,7 +75,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @return array
*/
public
function
getMediaFiles
()
:
array
public
function
getMediaFiles
()
{
return
(
array
)
$this
->
getData
(
BlockEntryInterface
::
MEDIA_FILES
);
}
...
...
@@ -83,7 +83,7 @@ class BlockEntry extends Block implements BlockEntryInterface
/**
* @param array $files
*/
public
function
setMediaFiles
(
array
$files
)
:
void
public
function
setMediaFiles
(
array
$files
)
{
$this
->
setData
(
BlockEntryInterface
::
MEDIA_FILES
,
$files
);
}
...
...
This diff is collapsed.
Click to expand it.
Model/PageEntry.php
+
10
−
10
View file @
785de67d
...
...
@@ -11,7 +11,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @return string
*/
public
function
getKey
()
:
string
public
function
getKey
()
{
return
(
string
)
$this
->
getData
(
PageEntryInterface
::
KEY
);
}
...
...
@@ -19,7 +19,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @param string $key
*/
public
function
setKey
(
string
$key
):
void
public
function
setKey
(
$key
)
{
$this
->
setData
(
PageEntryInterface
::
KEY
,
$key
);
}
...
...
@@ -27,7 +27,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @return bool
*/
public
function
isMaintained
()
:
bool
public
function
isMaintained
()
{
return
(
bool
)
$this
->
getData
(
PageEntryInterface
::
IS_MAINTAINED
);
}
...
...
@@ -35,7 +35,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @param bool $isMaintained
*/
public
function
setIsMaintained
(
bool
$isMaintained
)
:
void
public
function
setIsMaintained
(
$isMaintained
)
{
$this
->
setData
(
PageEntryInterface
::
IS_MAINTAINED
,
$isMaintained
);
}
...
...
@@ -43,7 +43,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @return array
*/
public
function
getStores
()
:
array
public
function
getStores
()
{
return
(
array
)
$this
->
getData
(
PageEntryInterface
::
STORES
);
}
...
...
@@ -51,7 +51,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @param array $stores
*/
public
function
setStores
(
array
$stores
)
:
void
public
function
setStores
(
array
$stores
)
{
$this
->
setData
(
PageEntryInterface
::
STORES
,
$stores
);
}
...
...
@@ -59,7 +59,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @return string
*/
public
function
getMediaDirectory
()
:
string
public
function
getMediaDirectory
()
{
return
(
string
)
$this
->
getData
(
PageEntryInterface
::
MEDIA_DIRECTORY
);
}
...
...
@@ -67,7 +67,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @param string $path
*/
public
function
setMediaDirectory
(
string
$path
)
:
void
public
function
setMediaDirectory
(
string
$path
)
{
$this
->
setData
(
PageEntryInterface
::
MEDIA_DIRECTORY
,
$path
);
}
...
...
@@ -75,7 +75,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @return array
*/
public
function
getMediaFiles
()
:
array
public
function
getMediaFiles
()
{
return
(
array
)
$this
->
getData
(
PageEntryInterface
::
MEDIA_FILES
);
}
...
...
@@ -83,7 +83,7 @@ class PageEntry extends Page implements PageEntryInterface
/**
* @param array $files
*/
public
function
setMediaFiles
(
array
$files
)
:
void
public
function
setMediaFiles
(
array
$files
)
{
$this
->
setData
(
PageEntryInterface
::
MEDIA_FILES
,
$files
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment